initial change - add pipeline entry to kubeflow registry #1973
Conversation
|
/assign @Ark-kun |
|
The tests failed with formatting error. Is there any tool I can use to format jsonnet code? |
|
@IronPan |
kubeflow/pipeline/all.libsonnet
Outdated
| local pipeline_scheduledworkflow = import "kubeflow/pipeline/pipeline-scheduledworkflow.libsonnet", | ||
| local pipeline_persistenceagent = import "kubeflow/pipeline/pipeline-persistenceagent.libsonnet", | ||
| local pipeline_ui = import "kubeflow/pipeline/pipeline-ui.libsonnet", | ||
| local spartakus = import "kubeflow/pipeline/spartakus.libsonnet", |
There was a problem hiding this comment.
spartakus is also available here: https://github.com/kubeflow/kubeflow/blob/master/kubeflow/core/prototypes/spartakus.jsonnet
Can we merge this two?
There was a problem hiding this comment.
Will pipeline always be installed? If so maybe we can remove it .
There was a problem hiding this comment.
The plan is to install pipelines by default.
@abhi-g is looking into how we can provide additional information (e.g. about installed components) with spartakus.
So maybe we can remove spartakus for now and look into how to add pipeline specific data to that.
There was a problem hiding this comment.
The plan is to install pipelines by default.
@abhi-g is looking into how we can provide additional information (e.g. about installed components) with spartakus.
So maybe we can remove spartakus for now and look into how to add pipeline specific data to that.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kunmingg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test kubeflow-presubmit |
* add pipeline entry * use camel case for params * formatting * format * fix * remove spartakus
* Add IronPan as Argo owner (#1974) * initial change - add pipeline entry to kubeflow registry (#1973) * add pipeline entry * use camel case for params * formatting * format * fix * remove spartakus * Add IronPan to pipeline ks package owner (#1980) * Add IronPan to pipeline ks package owner * Update OWNERS * cherry-pick pipeline component onto 0.3-branch * remove travis config (#1790)
* add pipeline entry * use camel case for params * formatting * format * fix * remove spartakus
* initial change - add pipeline entry to kubeflow registry (#1973) * add pipeline entry * use camel case for params * formatting * format * fix * remove spartakus * merge 01f4bc2 * merge b5bfe47 * grant KF user SA CMLE admin permission (#2013) * Activate CMLE during one-click deployment (#2017) * merge 14ff472 * add permission to get pod's log (#2037) Pipeline component needs the permission to get tf serving pod log https://github.com/kubeflow/pipelines/blob/master/components/kubeflow/deployer/src/deploy.sh#L202 * Add roles/dataproc.editor for kubeflow user account (#2035) Pipeline needs the dataproc editor permission to run the xgboost dataproc samples For details, see https://github.com/kubeflow/pipelines/tree/master/components/dataproc * Update Pipeline version to v0.1.3 (#2045) * merge 21ff6ce * resolve conflict * Update kf_app.yaml * add central dashboard * merge
* initial change - add pipeline entry to kubeflow registry (#1973) * add pipeline entry * use camel case for params * formatting * format * fix * remove spartakus * merge 01f4bc2 * merge b5bfe47 * grant KF user SA CMLE admin permission (#2013) * Activate CMLE during one-click deployment (#2017) * merge 14ff472 * add permission to get pod's log (#2037) Pipeline component needs the permission to get tf serving pod log https://github.com/kubeflow/pipelines/blob/master/components/kubeflow/deployer/src/deploy.sh#L202 * Add roles/dataproc.editor for kubeflow user account (#2035) Pipeline needs the dataproc editor permission to run the xgboost dataproc samples For details, see https://github.com/kubeflow/pipelines/tree/master/components/dataproc * Update Pipeline version to v0.1.3 (#2045) * merge 21ff6ce * resolve conflict * Update kf_app.yaml * add central dashboard * merge * Add job to load pipeline samples (#2071) * Add job to load pipeline samples Adding a job meets the requirement of - Load samples once when pipeline is deployed - Not run job again during kf upgrade - If loading samples failed, not blocking api server from start * format * update pipeline version (#2151) * update pipeline version * Update Dockerfile
* add pipeline entry * use camel case for params * formatting * format * fix * remove spartakus
Mostly copied from existing registry
https://github.com/kubeflow/pipelines/tree/master/ml-pipeline/ml-pipeline
I'll have a separate PR to integrate the one-click and kfctl deployment
This change is