Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Pytorch v1beta1 image #1978

Merged
merged 1 commit into from Nov 22, 2018
Merged

Adding Pytorch v1beta1 image #1978

merged 1 commit into from Nov 22, 2018

Conversation

johnugeorge
Copy link
Member

@johnugeorge johnugeorge commented Nov 20, 2018 •
edited by jlewi

  1. New docker image with v1beta1 binary is added
  2. v1beta1 version is included by default
  3. v1alpha1 version is removed

This change is Reviewable

@johnugeorge johnugeorge changed the title WIP:Adding Pytorch v1beta1 image Adding Pytorch v1beta1 image Nov 20, 2018
@kunmingg
Copy link
Contributor

/lgtm

@johnugeorge
Copy link
Member Author

/approve

@johnugeorge
Copy link
Member Author

/assign @richardsliu

@richardsliu
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johnugeorge
Copy link
Member Author

/retest

2 similar comments
@johnugeorge
Copy link
Member Author

/retest

@johnugeorge
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit fee939d into kubeflow:master Nov 22, 2018
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
@johnugeorge @k8s-ci-robot
Adding Pytorch v1beta1 image (kubeflow#1978)
a2f93b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhi-g abhi-g Awaiting requested review from abhi-g

@pdmack pdmack Awaiting requested review from pdmack

Assignees

@kunmingg kunmingg

@richardsliu richardsliu

Labels
approved cla: yes lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@johnugeorge @kunmingg @richardsliu @k8s-ci-robot @googlebot