Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Seldon Cluster Roles by default #2039

Merged
merged 2 commits into from Jan 4, 2019
Merged

Remove Seldon Cluster Roles by default #2039

merged 2 commits into from Jan 4, 2019

Conversation

ukclivecox
Copy link
Contributor

@ukclivecox ukclivecox commented Dec 4, 2018

  • Adds an optional parameter to include ClusterRoles, false by default.

Fixes #1452


This change is Reviewable

@ukclivecox
Copy link
Contributor Author

/assign @jlewi

@ukclivecox ukclivecox changed the title Remove Cluster Roles by default Remove Seldon Cluster Roles by default Dec 4, 2018
@ukclivecox
Copy link
Contributor Author

/retest

@jlewi
Copy link
Contributor

jlewi commented Dec 7, 2018

Thanks @cliveseldon
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlewi
Copy link
Contributor

jlewi commented Jan 4, 2019

/test all

@k8s-ci-robot k8s-ci-robot merged commit ec7820e into kubeflow:master Jan 4, 2019
kkasravi pushed a commit to kkasravi/kubeflow that referenced this pull request Feb 8, 2019
* Remove Cluster Roles by default

* Fix jsonnet formatting
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
* Remove Cluster Roles by default

* Fix jsonnet formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants