Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gcp-deployer] Package size fix, client id and secret textfield styling fix #2139

Merged
merged 1 commit into from Dec 20, 2018

Conversation

yebrahim
Copy link
Contributor

@yebrahim yebrahim commented Dec 20, 2018

  • Importing material-ui core components using non-default imports causes the entire library to be bundled with the app.
  • Fixed styling for the client id and secret fields.
  • The remaining is white-space fixes using vscode auto-format.

/assign @kunmingg


This change is Reviewable

@kunmingg
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kunmingg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ae4b380 into kubeflow:master Dec 20, 2018
@yebrahim yebrahim deleted the ui-fixes branch December 21, 2018 21:14
@yebrahim yebrahim changed the title Package size fix, client id and secret textfield styling fix [gcp-deployer] Package size fix, client id and secret textfield styling fix Feb 25, 2019
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
surajkota pushed a commit to surajkota/kubeflow that referenced this pull request Jun 13, 2022
* Update manifests for Katib v0.13.0-rc.1 release

* Change README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants