Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gcp-deployer] Style fixes #2158

Merged
merged 2 commits into from Dec 21, 2018
Merged

[gcp-deployer] Style fixes #2158

merged 2 commits into from Dec 21, 2018

Conversation

yebrahim
Copy link
Contributor

@yebrahim yebrahim commented Dec 21, 2018 •
edited by jlewi

This PR:

  • Updates dependencies to latest. This resolves a few issues with the material UI library used for the UI, such that most of the theme overrides aren't needed anymore.
  • Uses material style checkbox and dropdown controls.
  • Removes glamorous since it's deprecated, and switches to using inline styling, which is enough for an app this size.
  • Makes some other small improvements.

/assign @kunmingg

This change is Reviewable

@jlewi
Copy link
Contributor

jlewi commented Dec 21, 2018

LGTM
But lets wait for #2062 to be merged since this will likely create merge conflicts.

@yebrahim
Copy link
Contributor Author

Rebased and resolved conflicts. PTAL.

@jlewi
Copy link
Contributor

jlewi commented Dec 21, 2018

Thanks.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 57a2029 into kubeflow:master Dec 21, 2018
@yebrahim yebrahim deleted the style-fixes branch December 21, 2018 21:14
@yebrahim yebrahim changed the title Style fixes [gcp-deployer] Style fixes Feb 25, 2019
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
@yebrahim @k8s-ci-robot
Style fixes (kubeflow#2158)
199e6ba 
* fix dropdowns, style fixes

* mark all fields as required
surajkota pushed a commit to surajkota/kubeflow that referenced this pull request Jun 13, 2022
@kimwnasptd
kserve: Update the Models web app (kubeflow#2158)
3b93df7 
Update the app's manifests to:
1. Work under the /kserve-endpoints prefix
2. Use the correct gatway in the manifests
3. Use the correct namespace in for the app's ConfigMap

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellistarn ellistarn Awaiting requested review from ellistarn

@jlewi jlewi Awaiting requested review from jlewi

Assignees

@jlewi jlewi

@kunmingg kunmingg

Labels
approved cla: yes lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yebrahim @jlewi @k8s-ci-robot @googlebot @kunmingg