New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update kf version to 0.3.5; add retry around IAM policy edit #2161
Conversation
} | ||
if (returnPloicy === undefined) { | ||
this.setState({ | ||
dialogTitle: 'Failed setting IAM policy, please verify if have permission', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Wording, here and below. "Failed to set/create X, please make sure you have enough permissions."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
just one minor comment.
@yebrahim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @kunmingg.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kunmingg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…w#2161) * update kf version to 0.3.5; add retry around IAM policy edit * update messages
This change is