Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kfctl.sh shouldn't fail if a user isn't explicitly in the IAM policy - 0.4 patch. #2188

Merged
merged 1 commit into from Dec 28, 2018

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented Dec 28, 2018

  • Checking the IAM policy for the email address is a hack to get
    the proper case for the user's email.

  • We need to allow for the possibilit that the user isn't explicitly
    in the IAM policy because they might have access through a group.

Related to #2186


This change is Reviewable

* Checking the IAM policy for the email address is a hack to get
  the proper case for the user's email.

* We need to allow for the possibilit that the user isn't explicitly
  in the IAM policy because they might have access through a group.

Related to kubeflow#2186
@jlewi
Copy link
Contributor Author

jlewi commented Dec 28, 2018

/assign @kunmingg
/assign @IMBurbank

@k8s-ci-robot
Copy link
Contributor

@jlewi: GitHub didn't allow me to assign the following users: IMBurbank.

Note that only kubeflow members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @kunmingg
/assign @IMBurbank

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlewi jlewi changed the title kfctl.sh shouldn't fail if a user isn't explicitly in the IAM policy. kfctl.sh shouldn't fail if a user isn't explicitly in the IAM policy - 0.4 patch. Dec 28, 2018
@kunmingg
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kunmingg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fec5b07 into kubeflow:v0.4-branch Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants