New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check the name of the deployment is < 25 characters on GCP #2191
Conversation
This patch attemps to address issue 2189 by checking that DEPLOYMENT_NAME is less than 25 characters, and that it does not contain a '.'. Fixes: kubeflow#2189
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Hi @jcastill. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
CLA signed |
CLAs look good, thanks! |
/assign @jlewi |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…#2191) This patch attemps to address issue 2189 by checking that DEPLOYMENT_NAME is less than 25 characters, and that it does not contain a '.'. Fixes: kubeflow#2189
…#2191) This patch attemps to address issue 2189 by checking that DEPLOYMENT_NAME is less than 25 characters, and that it does not contain a '.'. Fixes: kubeflow#2189
This patch attemps to address issue 2189 by checking that
DEPLOYMENT_NAME is less than 25 characters, and that it does
not contain a '.'.
Fixes: #2189
This change is