Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ambassador number of replicas configurable #1112 #2224

Merged
merged 1 commit into from Jan 8, 2019

Conversation

agemocui
Copy link
Contributor

@agemocui agemocui commented Jan 5, 2019

Fixes #1112.
Fix the test based on the change from the original PR #2049


This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @agemocui. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@agemocui
Copy link
Contributor Author

agemocui commented Jan 5, 2019

/assign jlewi

@gaocegege
Copy link
Member

/ok-to-test

@agemocui
Copy link
Contributor Author

agemocui commented Jan 6, 2019

/retest

@jlewi
Copy link
Contributor

jlewi commented Jan 7, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 628cd6d into kubeflow:master Jan 8, 2019
kkasravi pushed a commit to kkasravi/kubeflow that referenced this pull request Feb 8, 2019
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants