Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TabError in sync_images.py #2240

Merged
merged 2 commits into from Feb 2, 2019
Merged

Fix TabError in sync_images.py #2240

merged 2 commits into from Feb 2, 2019

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jan 8, 2019 •
edited

As discussed at #2230 (comment) Python 3 will treat TabErrors as syntax errors.

TabError: inconsistent use of tabs and spaces in indentation

@cheyang Your review please.

This change is Reviewable

@cclauss
Fix TabError in sync_images.py
06532c2 
As discussed at kubeflow#2230 (comment) Python 3 will treat TabErrors as syntax errors.  __TabError: inconsistent use of tabs and spaces in indentation__
@k8s-ci-robot
Copy link
Contributor

Hi @cclauss. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pdmack
Copy link
Member

pdmack commented Jan 8, 2019

/ok-to-test

@cclauss Would you consider contributing a flake8 check for our pre-submits? Something akin to
https://github.com/kubeflow/kubeflow/blob/master/testing/test_jsonnet.py

But maybe more idiomatic.

@cheyang
Copy link
Contributor

cheyang commented Jan 8, 2019

@cclauss Thank you for fixing this! It looks good to me.

cclauss added a commit to cclauss/kubeflow that referenced this pull request Jan 9, 2019
@cclauss
Create test_flake8.py
2337b28 
As @pdmack requested at kubeflow#2240 (comment) this file is a flake8 check for pre-submits.
@cclauss cclauss mentioned this pull request Jan 9, 2019
Merged
@jlewi
Copy link
Contributor

jlewi commented Feb 2, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2a0e5d4 into kubeflow:master Feb 2, 2019
@cclauss cclauss deleted the patch-1 branch February 2, 2019 23:31
kkasravi pushed a commit to kkasravi/kubeflow that referenced this pull request Feb 8, 2019
@cclauss
Fix TabError in sync_images.py (kubeflow#2240)
774fbde 
* Fix TabError in sync_images.py

As discussed at kubeflow#2230 (comment) Python 3 will treat TabErrors as syntax errors.  __TabError: inconsistent use of tabs and spaces in indentation__

* Update sync_images.py
k8s-ci-robot pushed a commit that referenced this pull request Feb 11, 2019
@cclauss @k8s-ci-robot
Create test_flake8.py (#2247)
63aed01 
* Create test_flake8.py

As @pdmack requested at #2240 (comment) this file is a flake8 check for pre-submits.

* Typo
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
@cclauss @k8s-ci-robot
Fix TabError in sync_images.py (kubeflow#2240)
f06f0bd 
* Fix TabError in sync_images.py

As discussed at kubeflow#2230 (comment) Python 3 will treat TabErrors as syntax errors.  __TabError: inconsistent use of tabs and spaces in indentation__

* Update sync_images.py
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
@cclauss @k8s-ci-robot
Create test_flake8.py (kubeflow#2247)
6ee26ac 
* Create test_flake8.py

As @pdmack requested at kubeflow#2240 (comment) this file is a flake8 check for pre-submits.

* Typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellistarn ellistarn Awaiting requested review from ellistarn

@kunmingg kunmingg Awaiting requested review from kunmingg

Assignees

@jlewi jlewi

Labels
approved cla: yes lgtm ok-to-test size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cclauss @k8s-ci-robot @pdmack @cheyang @jlewi @googlebot