Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove ghost registries; make kf version env var on deploy app #2265

Merged
merged 1 commit into from
Jan 12, 2019
Merged

remove ghost registries; make kf version env var on deploy app #2265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 8 additions & 3 deletions components/gcp-click-to-deploy/src/DeployForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,9 +188,14 @@ export default class DeployForm extends React.Component<any, DeployFormState> {
<div style={styles.row}>
<TextField select={true} label="Kubeflow version:" required={true} style={styles.input} variant="filled"
value={this.state.kfversion} onChange={this._handleChange('kfversion')}>
{versionList.map((version, i) => (
<MenuItem key={i} value={version}>{version}</MenuItem>
))}
{ process.env.REACT_APP_VERSIONS ?
process.env.REACT_APP_VERSIONS.split(',').map((version, i) => (
<MenuItem key={i} value={version}>{version}</MenuItem>
)) :
versionList.map((version, i) => (
<MenuItem key={i} value={version}>{version}</MenuItem>
))
}
</TextField>
</div>

Expand Down
6 changes: 0 additions & 6 deletions kubeflow/registry.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,12 @@ libraries:
application:
version: master
path: application
notebooks:
version: master
path: notebooks
metacontroller:
version: master
path: metacontroller
profiles:
version: master
path: profiles
core:
version: master
path: core
jupyter:
version: master
path: jupyter
Expand Down