Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherrypick changes to V0.4 branch #2274

Merged
merged 6 commits into from Jan 15, 2019

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Jan 14, 2019

This change is Reviewable

Loading the sample job has sporadically failures due to race condition creating the db foreign key. 
Retry on the job should succeed.
Avoid using job to load samples into pipeline system. 
The K8s Job doesn't work well because it's immutable once created, ksonnet throw an error of "merging object with existing state failure" in case of upgrading the system.
@kunmingg
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jan 14, 2019
@kunmingg
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan, kunmingg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pdmack
Copy link
Member

pdmack commented Jan 15, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 797bcb7 into kubeflow:v0.4-branch Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants