Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define signer_email in main to remove flake8 F821 #2229 #2283

Merged
merged 1 commit into from Jan 22, 2019

Conversation

philtremblay
Copy link
Contributor

@philtremblay philtremblay commented Jan 15, 2019

This change is Reviewable

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@k8s-ci-robot
Copy link
Contributor

Hi @philtremblay. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@philtremblay
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@jlewi
Copy link
Contributor

jlewi commented Jan 22, 2019

/assign @lluunn

@lluunn
Copy link
Contributor

lluunn commented Jan 22, 2019

thanks for the fix
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lluunn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lluunn
Copy link
Contributor

lluunn commented Jan 22, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot merged commit d158d94 into kubeflow:master Jan 22, 2019
@philtremblay philtremblay deleted the flake8issue branch January 23, 2019 14:16
kkasravi pushed a commit to kkasravi/kubeflow that referenced this pull request Feb 8, 2019
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants