Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase the number of mktemp template variables in download.sh #2304

Merged
merged 1 commit into from Jan 19, 2019

Conversation

tnthornton
Copy link
Contributor

@tnthornton tnthornton commented Jan 18, 2019

The call to mktemp in the download.sh script results in an error similar to the following when running the script from Alpine, in my case I was using busybox:

mktemp: Invalid argument

Which is easily reproducible outside of the download.sh script:

bash-4.3# mktemp -d /tmp/tmp.kubeflow-repo-XXXX
mktemp: Invalid argument

Once the number of template variables was increased to at least 6 places, the error was resolved:

bash-4.3# mktemp -d /tmp/tmp.kubeflow-repo-XXXXXX
/tmp/tmp.kubeflow-repo-XckJMKj

This change is Reviewable

- increase from 4 to 6 to add compatibility for busybox mktemp
@k8s-ci-robot
Copy link
Contributor

Hi @tnthornton. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tnthornton
Copy link
Contributor Author

/assign @jlewi

@jlewi
Copy link
Contributor

jlewi commented Jan 19, 2019

Thank you so much for the fix
/ok-to-test

@jlewi
Copy link
Contributor

jlewi commented Jan 19, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bed42e8 into kubeflow:master Jan 19, 2019
@tnthornton tnthornton deleted the bb-mktemp branch January 19, 2019 03:26
kkasravi pushed a commit to kkasravi/kubeflow that referenced this pull request Feb 8, 2019
- increase from 4 to 6 to add compatibility for busybox mktemp
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
- increase from 4 to 6 to add compatibility for busybox mktemp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants