Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix userguide issue223 #234

Merged
merged 3 commits into from Feb 12, 2018
Merged

Fix userguide issue223 #234

merged 3 commits into from Feb 12, 2018

Conversation

fxue
Copy link
Contributor

@fxue fxue commented Feb 12, 2018 •
edited

@k8s-ci-robot
Copy link
Contributor

Hi @fxue. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fxue fxue mentioned this pull request Feb 12, 2018
Closed
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@jlewi
Copy link
Contributor

jlewi commented Feb 12, 2018

Thank you!

@jlewi jlewi merged commit 09a56e2 into kubeflow:master Feb 12, 2018
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
@toshiiw @k8s-ci-robot
More DB unit tests (kubeflow#234)
04837a4 
* Fix EarlyStopParam and SuggestionParam DB methods

GetEarlyStopParamList and GetSuggestionParamList mixed up the column
order and they returned nothing. Also, SetEarlyStopParam didn't
return an ID properly.

Signed-off-by: IWAMOTO Toshihiro <iwamoto@valinux.co.jp>

* Add more DB UTs

Signed-off-by: IWAMOTO Toshihiro <iwamoto@valinux.co.jp>
elenzio9 pushed a commit to arrikto/kubeflow that referenced this pull request Oct 31, 2022
@terrytangyuan
Add a couple of Ant Financial members (kubeflow#234)
414ea47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlewi jlewi jlewi approved these changes

Assignees
No one assigned
Labels
needs-ok-to-test size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fxue @k8s-ci-robot @googlebot @jlewi @fei-xue