Dashboard v1 UI rewrite done #2361
Conversation
Rewrote the entire app in polymer (using CDNs), added logo, made a sidebar, using animations, responsive and a11y added, colors matched up to spec, iframe navifation added for links, conditional view logic added, responsive view with hamburger icon added, empty state added for activities page
|
/assign @ajayalfred |
- Added Sidebar footer with Privacy and Build (currently static) - Added Sidebar divider between menu and other items - Sidebar content now is colored a dimunitive color till highlighted - Sidebar active item no longer emboldens - Paper-tabs moved lower to match design spec, and slider for tabs made thicc
… the default view (blue) and the responsive view (darker)
|
/test all |
|
/assign @kunmingg |
|
@avdaredevil This is great. It would be good to demo this at one of the community meetings once its merged. |
|
@jlewi Thanks! Sounds good to me |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kunmingg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
🎉🎉🎉 |
There was a problem hiding this comment.
Sorry for the late review.
Was this merged by mistake though? I think we still have a few things to discuss here around using iframes and the choice of JS framework. Some pieces are also empty place holders now (namely Activities tab and namespace picker), should we keep only the working pieces in the UI?
| @@ -0,0 +1,22 @@ | |||
| <base href="https://cdn.rawgit.com/download/polymer-cdn/2.6.0/lib/"> | |||
There was a problem hiding this comment.
We should move away from using the CDN.
Separately, rawgit is going away, we shouldn't rely on it even in the interim.
| homeOrIframeViewIndex: {type: Number, value: 0}, | ||
| url: {type: String, value: ""}, | ||
| }} | ||
| static get observers() {return [ |
|
@yebrahim |
|
My comment was about the use of Polymer, I'm not aware of the backend parts. |
* Dashboard v1 complete UI Rewrote the entire app in polymer (using CDNs), added logo, made a sidebar, using animations, responsive and a11y added, colors matched up to spec, iframe navifation added for links, conditional view logic added, responsive view with hamburger icon added, empty state added for activities page * Added dashboard blurb to roadmap * Fixed a link issue on readme * A bunch of polish: - Added Sidebar footer with Privacy and Build (currently static) - Added Sidebar divider between menu and other items - Sidebar content now is colored a dimunitive color till highlighted - Sidebar active item no longer emboldens - Paper-tabs moved lower to match design spec, and slider for tabs made thicc * Sidebar colors variabalized and made alpha based, so they can work on the default view (blue) and the responsive view (darker)
|
Comment moved to a separate issue, as this PR is already merged. |
* Dashboard v1 complete UI Rewrote the entire app in polymer (using CDNs), added logo, made a sidebar, using animations, responsive and a11y added, colors matched up to spec, iframe navifation added for links, conditional view logic added, responsive view with hamburger icon added, empty state added for activities page * Added dashboard blurb to roadmap * Fixed a link issue on readme * A bunch of polish: - Added Sidebar footer with Privacy and Build (currently static) - Added Sidebar divider between menu and other items - Sidebar content now is colored a dimunitive color till highlighted - Sidebar active item no longer emboldens - Paper-tabs moved lower to match design spec, and slider for tabs made thicc * Sidebar colors variabalized and made alpha based, so they can work on the default view (blue) and the responsive view (darker)
Targets issue #2359
Responsive
TODOs
This change is