Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make click-deploy-test upload junit artifacts #2437

Merged
merged 6 commits into from Feb 10, 2019

Conversation

lluunn
Copy link
Contributor

@lluunn lluunn commented Feb 8, 2019

  • The test was not producing any junit and thus not shown on testgrid.
  • Also added some logging.
  • Fix some bugs

kubeflow/testing#301
#2364

/cc @kunmingg
/cc @jlewi


This change is Reviewable

@lluunn
Copy link
Contributor Author

lluunn commented Feb 8, 2019

/hold
testing

@lluunn
Copy link
Contributor Author

lluunn commented Feb 9, 2019

/hold cancel

@kunmingg
Copy link
Contributor

kunmingg commented Feb 9, 2019

/lgtm
/approve
Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kunmingg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lluunn
Copy link
Contributor Author

lluunn commented Feb 9, 2019

test failure is out of disk quota

@lluunn
Copy link
Contributor Author

lluunn commented Feb 9, 2019

#2401

@lluunn
Copy link
Contributor Author

lluunn commented Feb 10, 2019

/retest

1 similar comment
@lluunn
Copy link
Contributor Author

lluunn commented Feb 10, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 4dd51c2 into kubeflow:master Feb 10, 2019
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants