Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ingress entry for basic auth #2438

Merged
merged 1 commit into from Feb 11, 2019
Merged

ingress entry for basic auth #2438

merged 1 commit into from Feb 11, 2019

Conversation

kunmingg
Copy link
Contributor

@kunmingg kunmingg commented Feb 8, 2019 •
edited

Create new entry for basic auth ingress on GCP.
How to use:
Apply both:

gcp/basic-auth-ingress
common/basic-auth

This change is Reviewable

@kunmingg
Copy link
Contributor Author

kunmingg commented Feb 8, 2019

/assign @lluunn

@lluunn
Copy link
Contributor

lluunn commented Feb 9, 2019

basic-auth-ingress and iap-ingress have many duplicate code, should we merge them?
Controlled by param basicAuth?

@kunmingg
Copy link
Contributor Author

kunmingg commented Feb 9, 2019 •
edited

don't like param control here as:

  1. they require different kind of input:
    one is oauth pair
    another is username/password pair
  2. want to prevent user misunderstanding:
    change param won't change underlying ingress.

@lluunn
Copy link
Contributor

lluunn commented Feb 9, 2019

/lgtm
/approve

@jlewi
Copy link
Contributor

jlewi commented Feb 10, 2019

/lgtm
/approve

@cjwagner
Copy link
Member

/test all

@k8s-ci-robot k8s-ci-robot removed the lgtm label Feb 11, 2019
@lluunn
Copy link
Contributor

lluunn commented Feb 11, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi, lluunn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c160692 into kubeflow:master Feb 11, 2019
kimwnasptd pushed a commit to arrikto/kubeflow that referenced this pull request Feb 13, 2019
@kunmingg @kimwnasptd
ingress entry for basic auth (kubeflow#2438)
2f7e444
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
@kunmingg @k8s-ci-robot
ingress entry for basic auth (kubeflow#2438)
42bae1e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellistarn ellistarn Awaiting requested review from ellistarn

@jlewi jlewi Awaiting requested review from jlewi

Assignees

@jlewi jlewi

@lluunn lluunn

Labels
approved cla: yes lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kunmingg @lluunn @jlewi @cjwagner @k8s-ci-robot @googlebot