Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mpijobs and pods/log in kubebench rbac #2442

Merged
merged 1 commit into from Feb 14, 2019

Conversation

Jeffwan
Copy link
Member

@Jeffwan Jeffwan commented Feb 10, 2019

Grant kubebench service account permission to operate mpijobs and fetch pod logs


This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @Jeffwan. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Jeffwan
Copy link
Member Author

Jeffwan commented Feb 11, 2019

/cc @xyhuang

@rongou
Copy link
Member

rongou commented Feb 11, 2019

/lgtm

@Jeffwan
Copy link
Member Author

Jeffwan commented Feb 11, 2019

Can someone leave a ok-to-test label?

@Jeffwan
Copy link
Member Author

Jeffwan commented Feb 11, 2019

/test kubeflow-presubmit

@k8s-ci-robot
Copy link
Contributor

@Jeffwan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test kubeflow-presubmit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xyhuang
Copy link
Member

xyhuang commented Feb 11, 2019

/ok-to-test

@Jeffwan
Copy link
Member Author

Jeffwan commented Feb 11, 2019

Seems failures on resource now. code: RESOURCE_ERROR
/test kubeflow-presubmit

@Jeffwan
Copy link
Member Author

Jeffwan commented Feb 12, 2019

deploy-kubeflow-deploy_argo-test-argo-deploy 18s seems error not related to PR.
/test kubeflow-presubmit

@Jeffwan
Copy link
Member Author

Jeffwan commented Feb 12, 2019

/test kubeflow-presubmit

1 similar comment
@Jeffwan
Copy link
Member Author

Jeffwan commented Feb 13, 2019

/test kubeflow-presubmit

@richardsliu
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1349971 into kubeflow:master Feb 14, 2019
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants