New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional parameter ambassadorNodePort #2511
Conversation
… service nodePort only when ambassadorServiceType is NodePort and ambassadorNodePort is within the valid range [30000-32767]. By default this parameter is set to 0. If ambassadorServiceType is NodePort and ambassadorNodePort is outside the valid range, then Kubernetes will automatically assign an available nodePort.
Hi @iankoulski. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kunmingg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
… service nodePort only when ambassadorServiceType is NodePort and ambassadorNodePort is within the valid range [30000-32767]. By default this parameter is set to 0. If ambassadorServiceType is NodePort and ambassadorNodePort is outside the valid range, then Kubernetes will automatically assign an available nodePort. (kubeflow#2511)
… service nodePort only when ambassadorServiceType is NodePort and ambassadorNodePort is within the valid range [30000-32767]. By default this parameter is set to 0. If ambassadorServiceType is NodePort and ambassadorNodePort is outside the valid range, then Kubernetes will automatically assign an available nodePort. (kubeflow#2511)
Used to set the ambassador service nodePort only when ambassadorServiceType is NodePort and ambassadorNodePort is within the valid range [30000-32767]. By default this parameter is set to 0. If ambassadorServiceType is NodePort and ambassadorNodePort is outside the valid range, then Kubernetes will automatically assign an available nodePort.
Contributes to closing the following issues:
#630
#1525
This change is