Add ClusterRole and ClusterRole #2684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @avdaredevil |
|
/retest |
|
cc: @kunmingg (could you also take a look?) |
|
/approve |
avdaredevil
approved these changes
Mar 12, 2019
kunmingg
reviewed
Mar 12, 2019
| app: "centraldashboard", | ||
| }, | ||
| name: "centraldashboard", | ||
| namespace: params.namespace, |
There was a problem hiding this comment.
We don't need a namespace for ClusterRole as it's scope cross namespaces.
| app: "centraldashboard", | ||
| }, | ||
| name: "centraldashboard", | ||
| namespace: params.namespace, |
Remove namespace from ClusterRole and ClusterRoleBinding
|
Changes made. PTAL. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avdaredevil, kunmingg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 11, 2021
* Add ClusterRole and ClusterRole binding to allow Namespace and Events listing * Remove namespace Remove namespace from ClusterRole and ClusterRoleBinding
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 12, 2021
* Add ClusterRole and ClusterRole binding to allow Namespace and Events listing * Remove namespace Remove namespace from ClusterRole and ClusterRoleBinding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the Central Dashboard to list namespaces and also retrieve events from those namespaces to display on the Activities tab.
This change is