Add mount of pvc #270
Add mount of pvc #270
Conversation
While we were adding pvc for every jupyter instance, we didn't mount it anywhere. Let's mount it to work dir, as I assume this is dir where users will likely put their notebooks. This will ensure that work will be retained even if pod dies.
| ] | ||
| c.KubeSpawner.volume_mounts = [ | ||
| { | ||
| 'mountPath': '/home/jovyan/work', |
There was a problem hiding this comment.
Should everything in /home be on the PVC?
There was a problem hiding this comment.
well we have tf examples there too, which I think is a nice touch, and that would disappear.
There was a problem hiding this comment.
What about about putting it under, /mnt ? I'd like to make it more obvious which directories correspond to PD and which don't.
There was a problem hiding this comment.
jupyter tree lands in /home/jovyan, so if we put it in /mnt it won't be obvious how to use it by users.
There was a problem hiding this comment.
Ok. Please address other comments.
| @@ -91,3 +91,18 @@ def extra_resource_limits(self): | |||
| # How much disk space do we want? | |||
There was a problem hiding this comment.
Do we need to uncomment the line above that sets singleuser_fs_gid
#22 (comment)
Did you test if this works?
There was a problem hiding this comment.
yup, just tested more thoroughly:
- created notebook in work dir
- deleted jupyter pod
- recreated pod
- notebook was there
There was a problem hiding this comment.
AD. singleuser_fs_gid - just checked - we run container as root. That makes it work without gid gimmicks but it's different issue on it's own:)
|
/ok-to-test |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
…es to vizier-core (kubeflow#270) * Ensure vizier-core never been stuck too long waiting for DB conn Signed-off-by: Koichiro Den <den@valinux.co.jp> * Add standard Health gRPC service Signed-off-by: Koichiro Den <den@valinux.co.jp> * Change db.New to return error instead of exit(1) with log.Fatal Signed-off-by: Koichiro Den <den@valinux.co.jp> * Add SelectOne() to VizierDBInterface Signed-off-by: Koichiro Den <den@valinux.co.jp> * Rename import for later convenience Signed-off-by: Koichiro Den <den@valinux.co.jp> * Implement and register Health Server for Katib manager Signed-off-by: Koichiro Den <den@valinux.co.jp> * Add readiness/liveness probes to vizier-core Signed-off-by: Koichiro Den <den@valinux.co.jp> * Update test codebase Fixes: 61ac5607353 ("Add SelectOne() to VizierDBInterface") Signed-off-by: Koichiro Den <den@valinux.co.jp>
* Add Bobgy to kubeflow ci-team * Update ci-viewer.members.txt
While we were adding pvc for every jupyter instance, we didn't mount it
anywhere.
Let's mount it to work dir, as I assume this is dir where users will
likely put their notebooks. This will ensure that work will be retained
even if pod dies.
Fix #19
Fix #22
This change is