Move basic auth username/password to ENV #2713

gabrielwen · 2019-03-15T18:27:42Z

Relates to #2661

This change is

gabrielwen · 2019-03-15T18:28:13Z

/assign @jlewi

gabrielwen · 2019-03-15T18:28:20Z

/assign @kunmingg

jlewi · 2019-03-15T19:58:33Z

@gabrielwen Can you look at why the test failed and open an issue if the failure is unrelated to this PR?

kunmingg · 2019-03-15T19:59:26Z

Can we pass them during apply instead of save as ENV?
These might be too sensitive to save locally

gabrielwen · 2019-03-15T20:20:01Z

/test kubeflow-presubmit

gabrielwen · 2019-03-15T20:21:40Z

failure doesn't make sense to me, rerunning it.

Cloning into '/mnt/test-data-volume/kubeflow-presubmit-kfctl-go-2713-66ab02d-6331-e948/src/kubeflow/tf-operator'...
error: RPC failed; curl 56 GnuTLS recv error (-54): Error in the pull function.
fatal: The remote end hung up unexpectedly
fatal: early EOF
fatal: index-pack failed

gabrielwen · 2019-03-15T20:35:10Z

seems like something wrong with deepcopy:

util.py                     71 INFO     Makefile:72: recipe for target 'pkg/apis/apps/gcp/v1alpha1/zz_generated.deepcopy.go' failed
util.py                     71 INFO     make: *** [pkg/apis/apps/gcp/v1alpha1/zz_generated.deepcopy.go] Error 255
util.py                     45 INFO     Running: make build-kfctl
cwd=/mnt/test-data-volume/kubeflow-presubmit-kfctl-go-2713-66ab02d-6337-0d08/src/kubeflow/kubeflow/bootstrap
util.py                     60 INFO     Subprocess output:
util.py                     71 INFO     /root/go/bin/deepcopy-gen -i github.com/kubeflow/kubeflow/bootstrap/pkg/apis/apps/gcp/... -O zz_g
enerated.deepcopy
util.py                     71 INFO     F0315 20:26:27.057077    8649 deepcopy.go:126] Failed loading boilerplate: open k8s.io/code-gener
ator/hack/boilerplate.go.txt: no such file or directory
util.py                     71 INFO     Makefile:72: recipe for target 'pkg/apis/apps/gcp/v1alpha1/zz_generated.deepcopy.go' failed
util.py                     71 INFO     make: *** [pkg/apis/apps/gcp/v1alpha1/zz_generated.deepcopy.go] Error 255
util.py                     45 INFO     Running: make build-kfctl
cwd=/mnt/test-data-volume/kubeflow-presubmit-kfctl-go-2713-66ab02d-6337-0d08/src/kubeflow/kubeflow/bootstrap
util.py                     60 INFO     Subprocess output:
util.py                     71 INFO     /root/go/bin/deepcopy-gen -i github.com/kubeflow/kubeflow/bootstrap/pkg/apis/apps/gcp/... -O zz_g
enerated.deepcopy
util.py                     71 INFO     F0315 20:26:37.651054    9499 deepcopy.go:126] Failed loading boilerplate: open k8s.io/code-gener
ator/hack/boilerplate.go.txt: no such file or directory
util.py                     71 INFO     Makefile:72: recipe for target 'pkg/apis/apps/gcp/v1alpha1/zz_generated.deepcopy.go' failed
util.py                     71 INFO     make: *** [pkg/apis/apps/gcp/v1alpha1/zz_generated.deepcopy.go] Error 255
util.py                     45 INFO     Running: make build-kfctl
cwd=/mnt/test-data-volume/kubeflow-presubmit-kfctl-go-2713-66ab02d-6337-0d08/src/kubeflow/kubeflow/bootstrap
util.py                     60 INFO     Subprocess output:
util.py                     71 INFO     /root/go/bin/deepcopy-gen -i github.com/kubeflow/kubeflow/bootstrap/pkg/apis/apps/gcp/... -O zz_g
enerated.deepcopy
util.py                     71 INFO     F0315 20:26:48.012311   10346 deepcopy.go:126] Failed loading boilerplate: open k8s.io/code-gener
ator/hack/boilerplate.go.txt: no such file or directory
util.py                     71 INFO     Makefile:72: recipe for target 'pkg/apis/apps/gcp/v1alpha1/zz_generated.deepcopy.go' failed
util.py                     71 INFO     make: *** [pkg/apis/apps/gcp/v1alpha1/zz_generated.deepcopy.go] Error 255
generated xml file: /mnt/test-data-volume/kubeflow-presubmit-kfctl-go-2713-66ab02d-6337-0d08/output/artifacts/junit_kfctl-build-test.xml
========================== 1 failed in 143.72 seconds ==========================

gabrielwen · 2019-03-15T20:54:36Z

Issue filed: #2715

gabrielwen · 2019-03-15T22:12:50Z

/retest

gabrielwen · 2019-03-15T23:04:26Z

Fixes #2715

jlewi

#2705 E2E test should be submitted first. That way the test can then be used to verify this PR is working.

Reviewable status: 0 of 5 files reviewed, 3 unresolved discussions (waiting on @ellis-bigelow, @gabrielwen, and @kkasravi)

bootstrap/cmd/kfctl/cmd/init.go, line 56 at r2 (raw file):

		if useBasicAuth && (os.Getenv(kftypes.BASIC_AUTH_USERNAME) == "" ||
			os.Getenv(kftypes.BASIC_AUTH_PASSWORD) == "") {
			// Printing warning message instead of bailing out as both ENV are used in apply,

The comment isn't clear to me. Can you explain?

If we only need these env for apply and not init; can we check what the command is and only error out if we are running the command that requires it?

bootstrap/cmd/kfctl/cmd/init.go, line 58 at r2 (raw file):

			// Printing warning message instead of bailing out as both ENV are used in apply,
			// not init.
			log.Warnf("If using basic auth, need to set ENV %v and %v when running kfctl apply",

"you need to set the environment variable %s to the username you want to use to login and variable %s to the password you want to use."

bootstrap/pkg/apis/apps/group.go, line 51 at r2 (raw file):

	DefaultGkeApiVer    = "v1beta1"
	DefaultAppLabel     = "app.kubernetes.io/name"
	BASIC_AUTH_USERNAME = "BASIC_AUTH_USERNAME"

Lets call the environment variables
KUBEFLOW_USERNAME
KUBEFLOW_PASSWORD

gabrielwen · 2019-03-16T01:19:27Z

/retest

jlewi

#2705 Is merged. Can you rebase? You'll need to update the test to work with this change.

Reviewable status: 0 of 5 files reviewed, 3 unresolved discussions (waiting on @ellis-bigelow, @gabrielwen, and @kkasravi)

gabrielwen

Reviewable status: 0 of 6 files reviewed, 3 unresolved discussions (waiting on @ellis-bigelow, @jlewi, and @kkasravi)

bootstrap/cmd/kfctl/cmd/init.go, line 56 at r2 (raw file):

Previously, jlewi (Jeremy Lewi) wrote…

The comment isn't clear to me. Can you explain?

If we only need these env for apply and not init; can we check what the command is and only error out if we are running the command that requires it?

this is merely a friendly reminder to set the ENV variables.

bootstrap/cmd/kfctl/cmd/init.go, line 58 at r2 (raw file):

Previously, jlewi (Jeremy Lewi) wrote…

"you need to set the environment variable %s to the username you want to use to login and variable %s to the password you want to use."

Done.

bootstrap/pkg/apis/apps/group.go, line 51 at r2 (raw file):

Previously, jlewi (Jeremy Lewi) wrote…

Lets call the environment variables
KUBEFLOW_USERNAME
KUBEFLOW_PASSWORD

Done.

kunmingg · 2019-03-20T02:06:02Z

/lgtm
/approve

k8s-ci-robot · 2019-03-20T02:06:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kunmingg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [kunmingg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* disable kustomize * remove username/password from params * remove CliOption * add check in init * use ENV * remove from spec * revert comment * add GOPATH to fix test * rebase * update test for ENV username/password * add some logs * update * update * update naming

googlebot added the cla: yes label Mar 15, 2019

k8s-ci-robot requested review from ellistarn and kkasravi March 15, 2019 18:27

k8s-ci-robot added the size/M label Mar 15, 2019

k8s-ci-robot assigned jlewi Mar 15, 2019

k8s-ci-robot assigned kunmingg Mar 15, 2019

gabrielwen mentioned this pull request Mar 15, 2019

[WIP] Fix kfctl_go_test #2717

Closed

jlewi suggested changes Mar 15, 2019

View reviewed changes

jlewi reviewed Mar 16, 2019

View reviewed changes

gabrielwen added 9 commits March 18, 2019 11:12

disable kustomize

a96b22c

remove username/password from params

af87116

remove CliOption

91eb5e9

add check in init

175f4e6

use ENV

0b60900

remove from spec

7f8e98f

revert comment

0108c6c

add GOPATH to fix test

211401e

rebase

853d8fb

gabrielwen force-pushed the env branch from e727b78 to 853d8fb Compare March 18, 2019 18:22

gabrielwen added 2 commits March 18, 2019 11:43

update test for ENV username/password

c23ddc5

add some logs

7b54e50

gabrielwen mentioned this pull request Mar 18, 2019

make build-kfctl is failed during test #2715

Closed

gabrielwen added 3 commits March 19, 2019 17:29

Merge branch 'master' of github.com:kubeflow/kubeflow into env

c9b3b30

update

8b7502c

update

b0e44aa

gabrielwen commented Mar 20, 2019

View reviewed changes

gabrielwen added 2 commits March 19, 2019 17:43

Merge branch 'master' into env

973b19a

update naming

8d374e1

k8s-ci-robot added the lgtm label Mar 20, 2019

k8s-ci-robot added the approved label Mar 20, 2019

k8s-ci-robot merged commit 5f66d6e into kubeflow:master Mar 20, 2019

gabrielwen deleted the env branch March 20, 2019 02:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move basic auth username/password to ENV #2713

Move basic auth username/password to ENV #2713

gabrielwen commented Mar 15, 2019 •

edited by jlewi

gabrielwen commented Mar 15, 2019

gabrielwen commented Mar 15, 2019

jlewi commented Mar 15, 2019

kunmingg commented Mar 15, 2019

gabrielwen commented Mar 15, 2019

gabrielwen commented Mar 15, 2019

gabrielwen commented Mar 15, 2019

gabrielwen commented Mar 15, 2019 •

edited

gabrielwen commented Mar 15, 2019

gabrielwen commented Mar 15, 2019

jlewi left a comment

gabrielwen commented Mar 16, 2019

jlewi left a comment

gabrielwen left a comment

kunmingg commented Mar 20, 2019

k8s-ci-robot commented Mar 20, 2019

Move basic auth username/password to ENV #2713

Move basic auth username/password to ENV #2713

Conversation

gabrielwen commented Mar 15, 2019 • edited by jlewi

gabrielwen commented Mar 15, 2019

gabrielwen commented Mar 15, 2019

jlewi commented Mar 15, 2019

kunmingg commented Mar 15, 2019

gabrielwen commented Mar 15, 2019

gabrielwen commented Mar 15, 2019

gabrielwen commented Mar 15, 2019

gabrielwen commented Mar 15, 2019 • edited

gabrielwen commented Mar 15, 2019

gabrielwen commented Mar 15, 2019

jlewi left a comment

Choose a reason for hiding this comment

gabrielwen commented Mar 16, 2019

jlewi left a comment

Choose a reason for hiding this comment

gabrielwen left a comment

Choose a reason for hiding this comment

kunmingg commented Mar 20, 2019

k8s-ci-robot commented Mar 20, 2019

gabrielwen commented Mar 15, 2019 •

edited by jlewi

gabrielwen commented Mar 15, 2019 •

edited