fixes 'kfctl needs to support passing swagger spec to ks init from file'

[kkasravi]

fixes #2706, #2709

---

This change is 

[kkasravi]

/assign @jlewi

[kkasravi]

/assign @gabrielwen

[kkasravi]

/retest

[jlewi]

Marking this WIP until blocking PRs are merged.

[kkasravi]

/assign @kunmingg

[gabrielwen]

Reviewed 46 of 51 files at r1, 1 of 1 files at r2.
Reviewable status: 4 of 5 files reviewed, 3 unresolved discussions (waiting on @ashahba, @ellis-bigelow, and @kkasravi)

---

bootstrap/cmd/kfctl/cmd/root.go, line 46 at r1 (raw file):

var rootCmd = &cobra.Command{
	Use:   "kfctl",
	Short: "A kfdef tool to create kubeflow applications",

kfdef seems like a jargon?

---

bootstrap/pkg/kfapp/coordinator/coordinator.go, line 217 at r1 (raw file):

	if strings.Compare(validName, appName) != 0 {
		return nil, fmt.Errorf(`invalid name %v must consist of lower case alphanumeric characters, '-' or '.',
and must start and end with an alphanumeric character`, appName)

should we also check the length of app name?

---

bootstrap/pkg/apis/apps/kfdef/v1alpha1/application_types.go, line 34 at r1 (raw file):

	Hostname               string `json:"hostname,omitempty"`
	Zone                   string `json:"zone,omitempty"`
	BasicAuthUsername      string `json:"basicAuthUsername,omitempty"`

let's remove username/password from spec as user might accidentally check in sensitive information into source control. current logic is to read from ENV.

[kkasravi]

Reviewable status: 2 of 7 files reviewed, 3 unresolved discussions (waiting on @ashahba, @ellis-bigelow, and @gabrielwen)

---

bootstrap/cmd/kfctl/cmd/root.go, line 46 at r1 (raw file):

Previously, gabrielwen (Hung-Ting Wen) wrote…

kfdef seems like a jargon?

updated to something more poetic

---

bootstrap/pkg/kfapp/coordinator/coordinator.go, line 217 at r1 (raw file):

Previously, gabrielwen (Hung-Ting Wen) wrote…

should we also check the length of app name?

delegated to apimachinery validation of a DNSLabel

---

bootstrap/pkg/apis/apps/kfdef/v1alpha1/application_types.go, line 34 at r1 (raw file):

Previously, gabrielwen (Hung-Ting Wen) wrote…

let's remove username/password from spec as user might accidentally check in sensitive information into source control. current logic is to read from ENV.

Done.

[gabrielwen]

/lgtm

[kkasravi]

thanks

Reviewable status: 2 of 7 files reviewed, 3 unresolved discussions (waiting on @ashahba, @ellis-bigelow, and @gabrielwen)

---

bootstrap/cmd/kfctl/cmd/root.go, line 46 at r1 (raw file):

Previously, kkasravi (Kam Kasravi) wrote…

updated to something more poetic

Done.

[kkasravi]

@kunmingg @lluunn this is ready to merge

[lluunn]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lluunn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• bootstrap/OWNERS [lluunn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment