Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache k8s spec in kubeflow so it can be used by ksonnet lib #2765

Merged
merged 2 commits into from Mar 22, 2019

Conversation

kunmingg
Copy link
Contributor

@kunmingg kunmingg commented Mar 21, 2019

This change is Reviewable

@kkasravi
Copy link
Contributor

/lgtm

@kkasravi
Copy link
Contributor

/approve

1 similar comment
@kunmingg
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kkasravi, kunmingg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kunmingg
Copy link
Contributor Author

rebase to resolve conflict

@lluunn
Copy link
Contributor

lluunn commented Mar 22, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit b66cd6d into kubeflow:master Mar 22, 2019
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
…#2765)

* cache k8s spec in kubeflow so it can be used by ksonnet lib

* hold change for group.go since spec is not merged to master yet
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 12, 2021
…#2765)

* cache k8s spec in kubeflow so it can be used by ksonnet lib

* hold change for group.go since spec is not merged to master yet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants