New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "update" verb to pdb resource of mpi-job #2792
Conversation
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pdmack The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test all |
/retest |
Meh, same error. @terrytangyuan can you try rebasing please? I'm not sure which change that might be. |
/retest |
@pdmack Just rebased. |
/retest |
Hmm. This is a simple change. The failing tests are related to Argo. Is there another way to get this merged? |
/test all |
/retest |
1 similar comment
/retest |
/lgtm |
Sorry that took so long @terrytangyuan. |
@pdmack No worries. Thanks for the help! We definitely should look into the root cause for this though. |
Well, the retests were due to some quota issues in the kubeflow test infra. We're working on improved maintenance there, both human and automated. |
Sounds good. Thanks! |
This is required if gang scheduling is enabled. See MPI-Operator's RBAC here that requires "update" for pdb resource.
This change is