Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "update" verb to pdb resource of mpi-job #2792

Merged
merged 2 commits into from Mar 27, 2019

Conversation

terrytangyuan
Copy link
Member

@terrytangyuan terrytangyuan commented Mar 24, 2019

This is required if gang scheduling is enabled. See MPI-Operator's RBAC here that requires "update" for pdb resource.


This change is Reviewable

@pdmack
Copy link
Member

pdmack commented Mar 25, 2019

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pdmack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pdmack
Copy link
Member

pdmack commented Mar 25, 2019

/test all

@terrytangyuan
Copy link
Member Author

/retest

@pdmack
Copy link
Member

pdmack commented Mar 25, 2019

Meh, same error. @terrytangyuan can you try rebasing please? I'm not sure which change that might be.

@terrytangyuan
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 25, 2019
@terrytangyuan
Copy link
Member Author

@pdmack Just rebased.

@pdmack
Copy link
Member

pdmack commented Mar 25, 2019

/retest

@terrytangyuan
Copy link
Member Author

Hmm. This is a simple change. The failing tests are related to Argo. Is there another way to get this merged?

@pdmack
Copy link
Member

pdmack commented Mar 26, 2019

/test all

@pdmack
Copy link
Member

pdmack commented Mar 26, 2019

/retest

1 similar comment
@pdmack
Copy link
Member

pdmack commented Mar 27, 2019

/retest

@pdmack
Copy link
Member

pdmack commented Mar 27, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit cee0f6e into kubeflow:master Mar 27, 2019
@pdmack
Copy link
Member

pdmack commented Mar 27, 2019

Sorry that took so long @terrytangyuan.

@terrytangyuan terrytangyuan deleted the patch-1 branch March 27, 2019 14:17
@terrytangyuan
Copy link
Member Author

@pdmack No worries. Thanks for the help! We definitely should look into the root cause for this though.

@pdmack
Copy link
Member

pdmack commented Mar 27, 2019

Well, the retests were due to some quota issues in the kubeflow test infra. We're working on improved maintenance there, both human and automated.

@terrytangyuan
Copy link
Member Author

Sounds good. Thanks!

lluunn pushed a commit to lluunn/kubeflow that referenced this pull request Mar 28, 2019
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants