Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check CLIENT_ID/CLIENT_SECRET before acutal Apply #2803

Merged
merged 1 commit into from Mar 26, 2019
Merged

check CLIENT_ID/CLIENT_SECRET before acutal Apply #2803

merged 1 commit into from Mar 26, 2019

Conversation

gabrielwen
Copy link
Contributor

@gabrielwen gabrielwen commented Mar 25, 2019 •
edited by jlewi

Fixes #2752

  • Remove flag OAUTH_ID and OAUTH_SECRET as we don't want to persist it on disk/version control system.
  • Check ENV CLIENT_ID and CLIENT_SECRET before actually running Apply

This change is Reviewable

@gabrielwen
Copy link
Contributor Author

/assign @lluunn

@lluunn
Copy link
Contributor

lluunn commented Mar 25, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lluunn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gabrielwen
Copy link
Contributor Author

/test kubeflow-presubmit

2 similar comments
@gabrielwen
Copy link
Contributor Author

/test kubeflow-presubmit

@gabrielwen
Copy link
Contributor Author

/test kubeflow-presubmit

@k8s-ci-robot k8s-ci-robot merged commit 353834c into kubeflow:master Mar 26, 2019
@gabrielwen gabrielwen deleted the fail-precond branch March 26, 2019 00:58
prodonjs pushed a commit to prodonjs/kubeflow that referenced this pull request Mar 28, 2019
@gabrielwen @prodonjs
check CLIENT_ID/CLIENT_SECRET before acutal Apply (kubeflow#2803)
a9975a9
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
@gabrielwen @k8s-ci-robot
check CLIENT_ID/CLIENT_SECRET before acutal Apply (kubeflow#2803)
555832c
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 12, 2021
@gabrielwen @k8s-ci-robot
check CLIENT_ID/CLIENT_SECRET before acutal Apply (kubeflow#2803)
b52c488
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellistarn ellistarn Awaiting requested review from ellistarn

@kkasravi kkasravi Awaiting requested review from kkasravi

Assignees

@lluunn lluunn

Labels
approved cla: yes lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gabrielwen @lluunn @k8s-ci-robot @googlebot