Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retag jupyter images with tag v0.5.0 #2805

Merged
merged 2 commits into from Mar 25, 2019

Conversation

zabbasi
Copy link
Contributor

@zabbasi zabbasi commented Mar 25, 2019

built tf 2.0 and 1.13 images
retag all images to v0.5.0


This change is Reviewable

@zabbasi
Copy link
Contributor Author

zabbasi commented Mar 25, 2019

//assign @lluunn

@@ -21,25 +21,29 @@ spawnerFormDefaults:
image:
# The container Image for the user's Jupyter Notebook
# If readonly, this value must be a member of the list below
value: gcr.io/kubeflow-images-public/tensorflow-1.10.1-notebook-cpu:v-base-74ac37c-1214
value: gcr.io/kubeflow-images-public/tensorflow-1.10.1-notebook-cpu:v0.5.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the default?
If so, it's better to use a newer, 1.13.1 or 1.12.0

@lluunn
Copy link
Contributor

lluunn commented Mar 25, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lluunn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zabbasi
Copy link
Contributor Author

zabbasi commented Mar 25, 2019

/retest

1 similar comment
@zabbasi
Copy link
Contributor Author

zabbasi commented Mar 25, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit cefb791 into kubeflow:master Mar 25, 2019
prodonjs pushed a commit to prodonjs/kubeflow that referenced this pull request Mar 28, 2019
* retag jupyter images with tag v0.5.0

* updated the default jupyter image
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
* retag jupyter images with tag v0.5.0

* updated the default jupyter image
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 12, 2021
* retag jupyter images with tag v0.5.0

* updated the default jupyter image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants