Add kfctl E2E test on GCP with IAP #2814
Conversation
|
#2795 should be submitted first. |
|
Most recent failure was problem creating sandbox: kubeflow/testing#342 |
|
/test all |
jlewi
changed the title
|
Test passed! |
Related to: kubeflow#2610 E2E test for kfctl. * Make test names unique based on parameters.
|
/assign @gabrielwen |
|
@gabrielwen @kkasravi This should be ready to review. |
testing/kfctl/kfctl_go_test.py
Outdated
| @@ -71,10 +80,9 @@ def test_build_kfctl_go(app_path, project): | |||
| # username and password are passed as env vars and won't appear in the logs | |||
| run_with_retries([kfctl_path, "init", app_path, "-V", "--platform=gcp", | |||
| "--version=" + version, | |||
There was a problem hiding this comment.
should the PULL_NUMBER be used to fetch that PR from github
eg `kfctl init ... --version pull/os.getenv("PULL_NUMBER")
There was a problem hiding this comment.
Isn't that what's happening?
Although once #2831 we should just pull the configs from the local checkout of the source.
| init_args = ["--use_basic_auth"] | ||
| else: | ||
| # Owned by project kubeflow-ci-deployment. | ||
| os.environ["CLIENT_ID"] = "CJ4qVPLTi0j0GJMkONj7Quwt" |
There was a problem hiding this comment.
is it safe to put these into source control?
There was a problem hiding this comment.
Yes. CLIENT id's can only be used with specific URLs which we own and configure.
CLIENT_ID & SECRET aren't actually secret. e.g. if you use them in a webapp in client side JS they are visible.
|
Latest test failure is: But it looks like the pod actually got evicted because of the deadline. |
|
Woo Hoo! Tests are passing again. I had to increase the timeout. |
yea... timeout is becoming an issue on my end as well... |
|
@gabrielwen could you LGTM please? |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Recent test should be a flake. /test all |
* Add an E2E test for kfctl with IAP on GCP. Related to: kubeflow#2610 E2E test for kfctl. * Make test names unique based on parameters. * Revert to pulling HEAD. * Fix comment. * Set requests & limits. * Increase timeout. * Add a comment.
* Add an E2E test for kfctl with IAP on GCP. Related to: kubeflow#2610 E2E test for kfctl. * Make test names unique based on parameters. * Revert to pulling HEAD. * Fix comment. * Set requests & limits. * Increase timeout. * Add a comment.
* Add an E2E test for kfctl with IAP on GCP. Related to: kubeflow#2610 E2E test for kfctl. * Make test names unique based on parameters. * Revert to pulling HEAD. * Fix comment. * Set requests & limits. * Increase timeout. * Add a comment.
Related to #2610 E2E test for go binary
This change is