New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the ksonnet configs #284
Conversation
* Configure the volume mounts correctly for Azure. * Add a parameter to set the DefaultTfImage.
But ESP doesn't seem to reject traffic that went around IAP.
…onnecting directly to the hub. That turns out not to work so well.
… corrupt." This reverts commit 74273c7. To see if this fixes the invalid jsonnet.
… the latest changes at head.
* Don't run Envoy as a side car in the JupyterHub pod. This is cleaner and allows us to have a single reverse proxy for all services.
Reviewed 13 of 13 files at r1. kubeflow/core/test.jsonnet, line 1 at r1 (raw file):
This file should be removed Comments from Reviewable |
Review status: all files reviewed at latest revision, 1 unresolved discussion. kubeflow/core/test.jsonnet, line 1 at r1 (raw file): Previously, ankushagarwal (Ankush Agarwal) wrote…
Thanks. I see now that it was moved. Comments from Reviewable |
* Update org.yaml * Update org.yaml
Refactor the core components; move most of the logic out of the prototype and into the libsonnet file
to pick up changes.
Move functions related NFS into nfs.libsonnet
Run the autoformatter.
This change is