Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the ksonnet configs #284

Merged
merged 54 commits into from Feb 23, 2018
Merged

Refactor the ksonnet configs #284

merged 54 commits into from Feb 23, 2018

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented Feb 23, 2018

  • Refactor the core components; move most of the logic out of the prototype and into the libsonnet file

    • This makes it easier to debug/develop/upgrade since we don't have to regenerate a component
      to pick up changes.
  • Move functions related NFS into nfs.libsonnet

  • Run the autoformatter.


This change is Reviewable

* Configure the volume mounts correctly for Azure.
* Add a parameter to set the DefaultTfImage.
But ESP doesn't seem to reject traffic that went around IAP.
…onnecting directly to the hub. That turns out not to work so well.
… corrupt."

This reverts commit 74273c7.

To see if this fixes the invalid jsonnet.
* Don't run Envoy as a side car in the JupyterHub pod. This is cleaner
  and allows us to have a single reverse proxy for all services.
@ankushagarwal
Copy link
Contributor

Reviewed 13 of 13 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


kubeflow/core/test.jsonnet, line 1 at r1 (raw file):

local util = import 'util.libsonnet';

This file should be removed


Comments from Reviewable

@jlewi
Copy link
Contributor Author

jlewi commented Feb 23, 2018

Review status: all files reviewed at latest revision, 1 unresolved discussion.


kubeflow/core/test.jsonnet, line 1 at r1 (raw file):

Previously, ankushagarwal (Ankush Agarwal) wrote…

This file should be removed

Thanks. I see now that it was moved.


Comments from Reviewable

@jlewi jlewi merged commit 0661389 into kubeflow:master Feb 23, 2018
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
elenzio9 pushed a commit to arrikto/kubeflow that referenced this pull request Oct 31, 2022
* Update org.yaml

* Update org.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants