Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jsonnet autoformat script #286

Merged
merged 3 commits into from Feb 26, 2018
Merged

Update jsonnet autoformat script #286

merged 3 commits into from Feb 26, 2018

Conversation

ankushagarwal
Copy link
Contributor

@ankushagarwal ankushagarwal commented Feb 23, 2018

Enforce consistent string quote styling
and comment styling

Autoformat all files in the project.


This change is Reviewable

jlewi
jlewi previously approved these changes Feb 24, 2018
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@jlewi
Copy link
Contributor

jlewi commented Feb 24, 2018

Actually can you run the script so we update all the files?

Ankush Agarwal added 2 commits February 24, 2018 20:41
Enforce consistent string quote styling
and comment styling
@jlewi jlewi merged commit f9d9401 into kubeflow:master Feb 26, 2018
@ankushagarwal ankushagarwal deleted the autofmt branch March 7, 2018 18:32
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
elenzio9 pushed a commit to arrikto/kubeflow that referenced this pull request Oct 31, 2022
* There was an indentation error and one of the members isn't an org member.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants