Add support for Python 2 kernels to the tensorflow notebook images. #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Dockerfiles for these images previously tried to install the Python 2 kernel, but omitted the `source activate` step prior to the install step. The result was that rather than installing the Python 2 kernel at the user level, it reinstalled the Python 3 kernel which simply duplicated the existing, globall-installed kernel. With this change "Python 2" now shows up as an option in the Jupyter UI when creating a new notebook, and in an existing notebook you can switch from a Python 3 to a Python 2 kernel using the "kernel" menu. This change is a prerequisite to addressing kubeflow#244, as the tf.Transform library relys on Apache Beam, which currently only supports Python 2. After this change lands, we should be able to add tf.Transform to the `ipykernel_py2` Conda environment, and then it will be usable in Python 2 kernels.
|
/ok-to-test |
jlewi
approved these changes
Mar 1, 2018
|
/approve |
|
@ojarjur Thanks for the quick fix! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jlewi Synced. |
yanniszark
pushed a commit
to arrikto/kubeflow
that referenced
this pull request
Feb 15, 2021
* add validating webhook for studyJob If create/update a studyJob with bad CR manifest or invalid configuration, k8s api server will reject the request. Fixes: kubeflow#314 * add test * allow check "kubectl" error code
elenzio9
pushed a commit
to arrikto/kubeflow
that referenced
this pull request
Oct 31, 2022
…m org members (kubeflow#314) Remove bobgy, james-jwu, k8s-ci-robot, rmgogogo from org members, as they were added to org admins To fix github sync error: "Configuration failed: failed to configure kubeflow members: users in both roles: bobgy, james-jwu, k8s-ci-robot, rmgogogo"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dockerfiles for these images previously tried to install the
Python 2 kernel, but omitted the
source activatestep priorto the install step.
The result was that rather than installing the Python 2 kernel
at the user level, it reinstalled the Python 3 kernel which simply
duplicated the existing, globall-installed kernel.
With this change "Python 2" now shows up as an option in the Jupyter
UI when creating a new notebook, and in an existing notebook you
can switch from a Python 3 to a Python 2 kernel using the "kernel"
menu.
This change is a prerequisite to addressing #244, as the tf.Transform
library relys on Apache Beam, which currently only supports Python 2.
After this change lands, we should be able to add tf.Transform to
the
ipykernel_py2Conda environment, and then it will be usablein Python 2 kernels.
This change is