Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick pipeline-runner ClusterRole changes (#2556) to pipelines branch #3293

Merged
merged 1 commit into from
May 17, 2019
Merged

Cherry-pick pipeline-runner ClusterRole changes (#2556) to pipelines branch #3293

merged 1 commit into from
May 17, 2019

Conversation

elikatsis
Copy link
Member

@elikatsis elikatsis commented May 16, 2019 •
edited by jlewi
Loading

This change is Reviewable

@elikatsis
Add extra permissions to ClusterRole 'pipeline-runner'
864dc67 
* Add verb "get" for PVC resource
* Add verbs ["create", "delete", "get"] for VolumeSnapshot resource

Signed-off-by: Ilias Katsakioris <elikatsis@arrikto.com>
@elikatsis elikatsis mentioned this pull request May 16, 2019
Closed
@neuromage
Copy link
Contributor

Hi @elikatsis

For my understanding, what is the purpose behind this permission change? Apologies, as I'm lacking some context here.

/cc @IronPan

@k8s-ci-robot k8s-ci-robot requested a review from IronPan May 17, 2019 01:18
@elikatsis
Copy link
Member Author

@neuromage
Hello Ajay,
To use kubeflow/pipelines#926, pipeline-runner needs to be able to manipulate PVCs and VolumeSnapshots.

I didn't know I should have PR'd on pipelines branch, so I had made it on master (see #2556).
Now that I'm adding E2E tests to cover the aforementioned PR (kubeflow/pipelines#1342), I've seen that kubeflow is deployed using pipelines branch, and the permissions are needed for the test to be successful.

@neuromage
Copy link
Contributor

Got it, thanks for the explanation.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neuromage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 828705f into kubeflow:pipelines May 17, 2019
@Ark-kun
Copy link
Contributor

Ark-kun commented May 23, 2019

/cc @vicaire @IronPan

@k8s-ci-robot k8s-ci-robot requested a review from vicaire May 23, 2019 20:55
@elikatsis elikatsis mentioned this pull request Jun 28, 2019
Merged
@elikatsis elikatsis deleted the cherry-pick-2556 branch May 19, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellistarn ellistarn Awaiting requested review from ellistarn

@neuromage neuromage Awaiting requested review from neuromage

@IronPan IronPan Awaiting requested review from IronPan

@vicaire vicaire Awaiting requested review from vicaire

Assignees

@neuromage neuromage

Labels
approved cla: yes lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@elikatsis @neuromage @k8s-ci-robot @Ark-kun @googlebot