Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify JupyterHub and Jupyter description in component readme #333

Merged
merged 1 commit into from Mar 3, 2018

Conversation

willingc
Copy link
Contributor

@willingc willingc commented Mar 2, 2018

  • Add reference to Project Jupyter a non-profit open source academic research project
  • Edit text and links related to Jupyter, JupyterLab, and JupyterHub
  • Correct minor typos and grammar

This change is Reviewable

@jlewi
Copy link
Contributor

jlewi commented Mar 3, 2018

/lgtm
/approve

@jlewi
Copy link
Contributor

jlewi commented Mar 3, 2018

@willingc Thank you. Can you please resync the files got out of date.

@jlewi
Copy link
Contributor

jlewi commented Mar 3, 2018

@willingc If you'd like your non-profit to be listed as one of the participants in Kubeflow (e.g. in slides like this

Just let myself and/or @aronchick know.

@jlewi
Copy link
Contributor

jlewi commented Mar 3, 2018

/ok-to-test

@willingc
Copy link
Contributor Author

willingc commented Mar 3, 2018

@willingc If you'd like your non-profit to be listed as one of the participants in Kubeflow (e.g. in slides like this

Just let myself and/or @aronchick know.

Thanks @jlewi. It would be nice to add Project Jupyter as a non-profit participant.

cc @minrk @yuvipanda @ellisonbg @fperez

@jlewi
Copy link
Contributor

jlewi commented Mar 3, 2018

@willingc Updated the slides.

Can you please resync when you have a chance files got out of sync again?

@willingc
Copy link
Contributor Author

willingc commented Mar 3, 2018

Thanks @jlewi for the update.

Is there a particular workflow that you recommend to avoid the resyncs?

@jlewi
Copy link
Contributor

jlewi commented Mar 3, 2018

/test all

@jlewi
Copy link
Contributor

jlewi commented Mar 3, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 83d4fc7 into kubeflow:master Mar 3, 2018
@jlewi
Copy link
Contributor

jlewi commented Mar 3, 2018

@willingc I think the resyncs were the result of our GitHub repo being misconfigured; se kubeflow/community#28. But It should be fixed now.

@willingc willingc deleted the component-jhub branch March 3, 2018 21:34
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Nov 1, 2019
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
elenzio9 pushed a commit to arrikto/kubeflow that referenced this pull request Oct 31, 2022
Also adds him to google and pipeline team
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants