Update repo commit. #3969
Update repo commit. #3969
Conversation
| - name: manifests | ||
| # TODO(jlewi): This is already outdated; need to pick up kubeflow/manifests#280 | ||
| uri: https://github.com/kubeflow/manifests/archive/a5c7fe3ce73d423baa2a271b19928d6a1ad0f587.tar.gz | ||
| uri: https://github.com/kubeflow/manifests/archive/6dc0c0d10a8060ff748a74da650776da1ba4e3b7.tar.gz |
There was a problem hiding this comment.
Why update the manifests? Is there particular changes?
There was a problem hiding this comment.
Looks like this is picking up the fix to the version.
https://github.com/kubeflow/manifests/commits/v0.6-branch
There was a problem hiding this comment.
yap, also updating image.
|
As discussed in slack; we are pinning to commits and not tags; to avoid having to to update things when we promote an RC to a final candidate. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Using v0.6.2-rc.1 for both kubeflow and manifests.
This change is