Fix 2 issues with s3 config from #387. #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @elsonrodriguez |
k8s-ci-robot
requested review from
elsonrodriguez
and removed request for
jimexist
|
Don't forget this one: https://github.com/kubeflow/kubeflow/pull/387/files#r173321462
|
* Use the params s3Enable not cloud to decide whether to enable S3 modifications. Use of S3 can be orthogonal to cloud. * Fix a typo in the variable name. * PR kubeflow#387 was automatically committed as a quirk of our auto-merge code even though there were outstanding comments.
|
Good catch (forgot to save the file. PTAL). |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inc0, lluunn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
elenzio9
pushed a commit
to arrikto/kubeflow
that referenced
this pull request
Oct 31, 2022
PRs: Manifest (kubeflow/manifests#1603) Website (kubeflow/website#1752) Reviews: Manifest(kubeflow/manifests#1621, kubeflow/manifests#1594, kubeflow/manifests#1582, kubeflow/manifests#1567) kfctl(kubeflow/kfctl#419) Website(kubeflow/website#2327) Issue Triage: kfctl(kubeflow/kfctl#428, kubeflow/kfctl#424, kubeflow/kfctl#418)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the params s3Enable not cloud to decide whether to enable S3 modifications. Use of S3 can be orthogonal to cloud.
Fix a typo in the variable name.
PR Refactor the TFServing component to better support GPUs and specific clouds #387 was automatically committed as a quirk of our auto-merge code
even though there were outstanding comments.
This change is