Replace ClusterRole/ClusterRoleBinding for ambassador with Role/RoleBinding #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Role/RoleBinding This change restricts the ambassador deployment to a single k8s namespace. The idea is that we should be able to deploy multiple instances of kubeflow to a single k8s cluster by restricting each kubeflow instance to a single namespace. Fixes #374
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lluunn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
elenzio9
pushed a commit
to arrikto/kubeflow
that referenced
this pull request
Oct 31, 2022
Revised wording of the readme.md file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change restricts the ambassador deployment to a single k8s
namespace. The idea is that we should be able to deploy multiple
instances of kubeflow to a single k8s cluster by restricting each
kubeflow instance to a single namespace.
Tested on my cluster and verified that ambassador and ambassador
admin both work fine after this change.
Related to #374
This change is