New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace azure env by aks || acs-engine #415
Conversation
/lgtm Might be a good idea to open issues to add
|
/retest |
New changes are detected. LGTM label has been removed. |
/retest |
/lgtm |
@wbuchwalter: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi, wbuchwalter The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Nvm, I can merge without it apparently. |
In azure there is two main ways to create a kubernetes cluster:
acs-engine
is the open source project used behing the scene by AKS. acs-engine receives features first and then they make their way to AKS.The NVIDIA driver installation was recently updated in acs-engine to make it simpler, and so the mount point are now different between the two platform.
acs-engine will also soon received the update to use NVIDIA device-plugin, so the two platform will use different configuration for a few months.
Consequently I replaced the
azure
cloud byaks
oracsengine
to avoid issues like this one: #414 (comment)Once the move to device-plugin is complete in AKS we will probably be able to entirely remove the cloud param since it won't be used anymore.
This change is