Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace azure env by aks || acs-engine #415

Merged
merged 2 commits into from Mar 19, 2018
Merged

Replace azure env by aks || acs-engine #415

merged 2 commits into from Mar 19, 2018

Conversation

wbuchwalter
Copy link
Contributor

@wbuchwalter wbuchwalter commented Mar 13, 2018

In azure there is two main ways to create a kubernetes cluster:

  • acs-engine
  • AKS

acs-engine is the open source project used behing the scene by AKS. acs-engine receives features first and then they make their way to AKS.
The NVIDIA driver installation was recently updated in acs-engine to make it simpler, and so the mount point are now different between the two platform.
acs-engine will also soon received the update to use NVIDIA device-plugin, so the two platform will use different configuration for a few months.

Consequently I replaced the azure cloud by aksor acsengine to avoid issues like this one: #414 (comment)

Once the move to device-plugin is complete in AKS we will probably be able to entirely remove the cloud param since it won't be used anymore.


This change is Reviewable

@jlewi
Copy link
Contributor

jlewi commented Mar 17, 2018

/lgtm
/approve

Might be a good idea to open issues to add

  1. ksonnet unittests for the Azure configs
  2. E2E testing on Azure.

@wbuchwalter
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 19, 2018
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@wbuchwalter
Copy link
Contributor Author

/retest

@wbuchwalter
Copy link
Contributor Author

/lgtm

@k8s-ci-robot
Copy link
Contributor

@wbuchwalter: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi, wbuchwalter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wbuchwalter
Copy link
Contributor Author

wbuchwalter commented Mar 19, 2018

@jlewi Can you re /lgtm? Had to pull master to fix issues with the presubmit hook. Thanks.

Nvm, I can merge without it apparently.

@wbuchwalter wbuchwalter merged commit 574317d into kubeflow:master Mar 19, 2018
@wbuchwalter wbuchwalter deleted the azure-doc branch March 19, 2018 14:43
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
elenzio9 pushed a commit to arrikto/kubeflow that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants