Libsonnet cleanup #431
Libsonnet cleanup #431
Conversation
kubeflow/core/ambassador.libsonnet
Outdated
| local ambassadorImage = "quay.io/datawire/ambassador:0.26.0", | ||
| service:: { | ||
| service(serviceType): { |
There was a problem hiding this comment.
Shouldn't this be service(serviceType)::
kubeflow/core/jupyterhub.libsonnet
Outdated
| local diskNames = util.toArray(disks), | ||
| local kubeSpawner = $.parts(namespace).kubeSpawner(jupyterHubAuthenticator, diskNames), | ||
| local cm = if std.length(diskNames) == 0 then | ||
| $.parts(namespace).jupyterHubConfigMapWithoutVolumes |
There was a problem hiding this comment.
jupyterHubConfigMapWithoutVolumes takes a parameter named spawner, but here you are not passing any parameter to jupyterHubConfigMapWithoutVolumes
There was a problem hiding this comment.
both parts of the if logic return a function which is then called with spawner on line # 24.
Original logic is similar.
There was a problem hiding this comment.
The first part of the if logic returns a function which takes spawner as a parameter, but the second part $.parts(namespace).jupyterHubConfigMapWithVolumes(diskNames) returns an object, not a function.
|
@ankushagarwal the logic related to jupyterHubConfigMapWithVolumes was never used or inserted. Instead params.disks is inserted via kubeSpawner and becomes part of jupyterhub_spawner.py. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankushagarwal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* AddPytorch operator manifests changes * Rebase from master * Removing v1beta2 run from workflow
/assign @ankushagarwal
fixes #417
This change is