Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the pip install tensorboard #446

Merged
merged 1 commit into from Mar 20, 2018

Conversation

kkasravi
Copy link
Contributor

@kkasravi kkasravi commented Mar 17, 2018

/assign @jlewi

This is for the issue #428 "remove tensorboard link from jupyter" and #297 "add prototypes for TensorBoard". In general we're utilizing the ksonnet way to launch tensorboard rather than using a button in jupyterhub.


This change is Reviewable

@kkasravi
Copy link
Contributor Author

screen shot 2018-03-17 at 10 16 57 am

this is a screen shot from a container i built for tensorflow-notebook-cpu and uploaded to hub.docker.com https://hub.docker.com/r/nervana/tensorflow-notebook-cpu/tags/

@kkasravi
Copy link
Contributor Author

/test

@jlewi
Copy link
Contributor

jlewi commented Mar 17, 2018

Thanks for this.

Could you update the PR description to explain why we ware making this change and link to the relevant issues? i.e. #428 to remove the link and #297 to add prototypes for TensorBoard.

@jlewi
Copy link
Contributor

jlewi commented Mar 17, 2018

@pdmack I think you helped a customer recently get this working. Any reason we should keep this rather than telling customers to directly launch TB and potentially providing a UI for that if we think one is needed?

@kkasravi
Copy link
Contributor Author

@jlewi updated the PR description

@kkasravi
Copy link
Contributor Author

/retest

@jlewi
Copy link
Contributor

jlewi commented Mar 20, 2018

/approve

@jlewi
Copy link
Contributor

jlewi commented Mar 20, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ae18cd1 into kubeflow:master Mar 20, 2018
@pdmack
Copy link
Member

pdmack commented Mar 20, 2018

@jlewi Sorry, too slow. I think clear instructions for accessing TB will be fine. The user wasn't aware that the menu item was there, and therefore tried to launch it from the NB terminal. Also, they were using a spawned image which had TB launch issues (even from the menu).

yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Nov 1, 2019
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
elenzio9 pushed a commit to arrikto/kubeflow that referenced this pull request Oct 31, 2022
* Update OWNERS

* Update OWNERS

* Update OWNERS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants