Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ambassador_test.jsonnet #476

Merged
merged 1 commit into from Mar 21, 2018
Merged

Fix ambassador_test.jsonnet #476

merged 1 commit into from Mar 21, 2018

Conversation

ankushagarwal
Copy link
Contributor

@ankushagarwal ankushagarwal commented Mar 21, 2018

It was broken by #396

/cc @wbuchwalter


This change is Reviewable

@ankushagarwal
Copy link
Contributor Author

/cc @jlewi
/cc @lluunn
Adding more folks since this is blocking all PRs

@lluunn
Copy link
Contributor

lluunn commented Mar 21, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lluunn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bdecba1 into kubeflow:master Mar 21, 2018
@ankushagarwal ankushagarwal deleted the fix_ambassador_test branch March 21, 2018 19:07
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
* katib manager db error

condition is keyword of mysql, we need escape it in sql

* fix test case error

* use status to replace condition as column name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants