Fix specifying of GPU resources. #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Resources need to be attached to the container; we were attaching them to the pod and as a result they were getting stripped out.
|
@foxish PTAL |
foxish
reviewed
Dec 21, 2017
kubeflow/tf-job/tf-job.libsonnet
Outdated
| "image": image, | ||
| "name": "tensorflow", | ||
| }; | ||
| local containerArgs = if std.length(args) >0 then |
foxish
previously approved these changes
Dec 21, 2017
|
Just that one nit. otherwise LGTM. |
kimwnasptd
pushed a commit
to arrikto/kubeflow
that referenced
this pull request
Mar 5, 2019
* Add gojek dsp group email To feast team members list. Ref Issue kubeflow#49 * Sort members alphabetically
yanniszark
pushed a commit
to arrikto/kubeflow
that referenced
this pull request
Feb 15, 2021
Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
VaishnaviHire
pushed a commit
to VaishnaviHire/kubeflow
that referenced
this pull request
Feb 2, 2023
Update owners in v1.6 branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resources need to be attached to the container; we were attaching them to the pod and as a result they were getting stripped out.
Fixes tf-cnn prototype doesn't add GPU resource requests #48