Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable tf serving gpu test #497

Merged
merged 1 commit into from Mar 28, 2018
Merged

Enable tf serving gpu test #497

merged 1 commit into from Mar 28, 2018

Conversation

lluunn
Copy link
Contributor

@lluunn lluunn commented Mar 23, 2018 •
edited

The test is flaky: #484
However, it's hard to reproduce the error, so I am going to re-enable it and see.

/cc @jlewi

This change is Reviewable

@lluunn
Copy link
Contributor Author

lluunn commented Mar 23, 2018

/retest

@lluunn
Copy link
Contributor Author

lluunn commented Mar 23, 2018

/test kubeflow-presubmit

4 similar comments
@lluunn
Copy link
Contributor Author

lluunn commented Mar 23, 2018

/test kubeflow-presubmit

@lluunn
Copy link
Contributor Author

lluunn commented Mar 23, 2018

/test kubeflow-presubmit

@lluunn
Copy link
Contributor Author

lluunn commented Mar 23, 2018

/test kubeflow-presubmit

@lluunn
Copy link
Contributor Author

lluunn commented Mar 23, 2018

/test kubeflow-presubmit

@lluunn
Copy link
Contributor Author

lluunn commented Mar 24, 2018

It's really hard to repro the failure...
I am guessing that because we have limited GPUs in the cluster, and there were multiple presubmits running, some of the test timeout waiting for the resource? @jlewi
Maybe we don't run this test for every presubmit, but only for postsubmit or periodic runs? WDYT?

@lluunn
Copy link
Contributor Author

lluunn commented Mar 24, 2018

/test kubeflow-presubmit

@lluunn lluunn changed the title [WIP] Fix tf serving gpu test Enable tf serving gpu test Mar 27, 2018
@lluunn
Copy link
Contributor Author

lluunn commented Mar 27, 2018

/cc @jlewi

@k8s-ci-robot k8s-ci-robot requested a review from jlewi March 27, 2018 21:07
@jlewi
Copy link
Contributor

jlewi commented Mar 28, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c0f9b49 into kubeflow:master Mar 28, 2018
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Nov 1, 2019
@Tabrizian @k8s-ci-robot
Update jupyter image tags (kubeflow#497)
99246dd
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
@lluunn @k8s-ci-robot
enable tf serving gpu test (kubeflow#497)
a8b45f3
elenzio9 pushed a commit to arrikto/kubeflow that referenced this pull request Oct 31, 2022
@andreyvelich
Add FPGA OWNERS to member list (kubeflow#497)
3d922bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbuchwalter wbuchwalter Awaiting requested review from wbuchwalter

@zjj2wry zjj2wry Awaiting requested review from zjj2wry

@jlewi jlewi Awaiting requested review from jlewi

Assignees

@jlewi jlewi

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lluunn @jlewi @k8s-ci-robot