Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http proxy default image #517

Merged
merged 1 commit into from Mar 27, 2018
Merged

Http proxy default image #517

merged 1 commit into from Mar 27, 2018

Conversation

lluunn
Copy link
Contributor

@lluunn lluunn commented Mar 27, 2018

  • Change the flag for deploying http proxy to bool.
  • Use a default image if user does not specify the image.

Fix #511


This change is Reviewable

@lluunn
Copy link
Contributor Author

lluunn commented Mar 27, 2018

/uncc wbuchwalter
/uncc zjj2wry
/cc jlewi
/cc yupbank

@k8s-ci-robot k8s-ci-robot requested review from jlewi and yupbank and removed request for wbuchwalter and zjj2wry March 27, 2018 21:25
@yupbank
Copy link
Member

yupbank commented Mar 27, 2018

/lgtm thanks !

@lluunn
Copy link
Contributor Author

lluunn commented Mar 27, 2018

The lgtm tag is not added, maybe /lgtm has to be on its own line?
@yupbank can you try again?
Thanks!

@yupbank
Copy link
Member

yupbank commented Mar 27, 2018

/lgtm

@lluunn
Copy link
Contributor Author

lluunn commented Mar 27, 2018

Thanks!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lluunn, yupbank

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 905c118 into kubeflow:master Mar 27, 2018
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
elenzio9 pushed a commit to arrikto/kubeflow that referenced this pull request Oct 31, 2022
Signed-off-by: Anna Jung (VMware) <antheaj@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants