Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add owners for the Notebooks Controller #5240

Conversation

kimwnasptd
Copy link
Member

@kimwnasptd kimwnasptd commented Aug 25, 2020

closes #5200

/cc @jlewi
/assign @kimwnasptd

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
@kubeflow-bot
Copy link
Contributor

This change is Reviewable

@jlewi
Copy link
Contributor

jlewi commented Aug 25, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7bb5ab1 into kubeflow:master Aug 25, 2020
@elikatsis elikatsis deleted the feature-kimwnasptd-notebooks-ctrlr-owners branch August 28, 2020 11:33
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 12, 2021
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notebook controller needs OWNERs file
4 participants