Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in tensorflow notebook images in spawner #526

Merged
merged 1 commit into from Mar 29, 2018
Merged

Fix typos in tensorflow notebook images in spawner #526

merged 1 commit into from Mar 29, 2018

Conversation

ankushagarwal
Copy link
Contributor

@ankushagarwal ankushagarwal commented Mar 29, 2018

Related to #506

This change is Reviewable

@ankushagarwal
Copy link
Contributor Author

/cc @jlewi

This should be cherry-picked in v0.1.0-branch

@k8s-ci-robot k8s-ci-robot requested a review from jlewi March 29, 2018 05:27
@jlewi
Copy link
Contributor

jlewi commented Mar 29, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit acd1ec9 into kubeflow:master Mar 29, 2018
@ankushagarwal ankushagarwal deleted the fix-tensorflow-version branch March 29, 2018 23:45
k8s-ci-robot pushed a commit that referenced this pull request Mar 30, 2018
* Fix typos in tensorflow notebook images in spawner

* Update the TFJob image in preparation for a new RC. (#533)

* The updated TFJob includes the fix to delete pods when job finishes
  rather than leave them running.

* We need to pin the commit of the tf-operator in the extra repos so
  that we checkout the tests at the commit that matches the image.
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
elenzio9 pushed a commit to arrikto/kubeflow that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants