Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tf1.7 to tensorflow-notebook images #543

Merged
merged 2 commits into from Apr 1, 2018
Merged

Add tf1.7 to tensorflow-notebook images #543

merged 2 commits into from Apr 1, 2018

Conversation

ankushagarwal
Copy link
Contributor

@ankushagarwal ankushagarwal commented Mar 30, 2018

/cc @jlewi


This change is Reviewable

@ankushagarwal
Copy link
Contributor Author

/retest

1 similar comment
@ankushagarwal
Copy link
Contributor Author

/retest

@jlewi
Copy link
Contributor

jlewi commented Mar 30, 2018

Note there is an issue with the CUDA version in our notebook images being too old for the newer versions of TF.
see #549

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 30, 2018
@ankushagarwal
Copy link
Contributor Author

We use cuda 8.0 for tf 1.4x.

We use cuda 9.0 for tf 1.5x and higher

I confirmed with someone on the tensorflow team that we need cuda 9.0 for tf1.7

@jlewi
Copy link
Contributor

jlewi commented Apr 1, 2018

Thanks
/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f1ee158 into kubeflow:master Apr 1, 2018
@ankushagarwal ankushagarwal deleted the tf17 branch April 3, 2018 17:32
swiftdiaries pushed a commit to swiftdiaries/kubeflow that referenced this pull request Apr 4, 2018
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
elenzio9 pushed a commit to arrikto/kubeflow that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants