Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable gpu test #547

Merged
merged 2 commits into from Mar 30, 2018
Merged

disable gpu test #547

merged 2 commits into from Mar 30, 2018

Conversation

lluunn
Copy link
Contributor

@lluunn lluunn commented Mar 30, 2018 •
edited by jlewi

It's failing in presubmit
/cc @ankushagarwal

This change is Reviewable

@ankushagarwal
Copy link
Contributor

/lgtm
/approve

@lluunn
Copy link
Contributor Author

lluunn commented Mar 30, 2018

/test kubeflow-presubmit

1 similar comment
@lluunn
Copy link
Contributor Author

lluunn commented Mar 30, 2018

/test kubeflow-presubmit

@lluunn
Copy link
Contributor Author

lluunn commented Mar 30, 2018

simple-tfjob failed... not sure why.

@jlewi
Copy link
Contributor

jlewi commented Mar 30, 2018

/lgtm
/approve

@jlewi
Copy link
Contributor

jlewi commented Mar 30, 2018

/test all

@jlewi jlewi mentioned this pull request Mar 30, 2018
Merged
@lluunn
Copy link
Contributor Author

lluunn commented Mar 30, 2018

simple-job is failing consistently in this PR, but passing in other PRs..

@ankushagarwal
Copy link
Contributor

My suspicion is that it is related to this commit which was merged yesterday in tf-operator : kubeflow/training-operator@a7511ff#diff-a21c288bd7c0a85dba041751952f4e29

The simple-tfjob seems to be stuck in the function wait_for_pods_to_be_deleted

The last commit in this repo updated the tf-operator image

@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 30, 2018
@lluunn
Copy link
Contributor Author

lluunn commented Mar 30, 2018

just synced

@ankushagarwal
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankushagarwal, jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ankushagarwal,jlewi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4581113 into kubeflow:master Mar 30, 2018
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
@lluunn @k8s-ci-robot
disable gpu test (kubeflow#547)
c1c41b4
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
@hougangliu @k8s-ci-robot
Fix nil pointer error when create trial (kubeflow#547)
ee37ba7
elenzio9 pushed a commit to arrikto/kubeflow that referenced this pull request Oct 31, 2022
Update org.yaml (kubeflow#547)
632e7cd 
Add Amber Graner (akgraner) - I'm a member of the Kubeflow release team and help in various of the areas of the community. - https://github.com/kubeflow/community/blob/master/releases/release-1.6/release-team.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankushagarwal ankushagarwal Awaiting requested review from ankushagarwal

Assignees

@jlewi jlewi

@ankushagarwal ankushagarwal

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lluunn @ankushagarwal @jlewi @k8s-ci-robot