Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rety upto 3 times while building tensorflow notebook images #559

Merged
merged 1 commit into from Apr 2, 2018
Merged

Rety upto 3 times while building tensorflow notebook images #559

merged 1 commit into from Apr 2, 2018

Conversation

ankushagarwal
Copy link
Contributor

@ankushagarwal ankushagarwal commented Apr 2, 2018

/cc @lluunn


This change is Reviewable

@@ -82,6 +82,9 @@
// command: List to pass as the container command.
local buildTemplate(step_name, command, env_vars=[], sidecars=[]) = {
name: step_name,
retryStrategy: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it flaky? Can you add some comment on why we need retry

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@lluunn
Copy link
Contributor

lluunn commented Apr 2, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lluunn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8f8e57d into kubeflow:master Apr 2, 2018
@ankushagarwal ankushagarwal deleted the tfma branch April 3, 2018 17:32
swiftdiaries pushed a commit to swiftdiaries/kubeflow that referenced this pull request Apr 4, 2018
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
* Adding metric name to GetObservationLogRequest

* regenerate mockdb
elenzio9 pushed a commit to arrikto/kubeflow that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants