Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

images: Add the link #614

Merged
merged 1 commit into from Apr 9, 2018
Merged

images: Add the link #614

merged 1 commit into from Apr 9, 2018

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Apr 8, 2018 •
edited by jlewi

/cc @jlewi

This change is Reviewable

@k8s-ci-robot k8s-ci-robot requested a review from jlewi April 8, 2018 03:35
@gaocegege
Copy link
Member Author

It seems that the CI failed in master, IMO.

@jlewi
Copy link
Contributor

jlewi commented Apr 8, 2018

There was a problem creating the VM for the test on minikube. The logs aren't that helpful

 File "/usr/lib/python2.7/runpy.py", line 174, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/mnt/test-data-volume/kubeflow-presubmit-kubeflow-e2e-minikube-614-0340221-1073-e21d/src/kubeflow/kubeflow/testing/test_deploy.py", line 657, in <module>
    main()
  File "/mnt/test-data-volume/kubeflow-presubmit-kubeflow-e2e-minikube-614-0340221-1073-e21d/src/kubeflow/kubeflow/testing/test_deploy.py", line 647, in main
    wrap_test(args)
  File "/mnt/test-data-volume/kubeflow-presubmit-kubeflow-e2e-minikube-614-0340221-1073-e21d/src/kubeflow/kubeflow/testing/test_deploy.py", line 307, in wrap_test
    test_util.wrap_test(run, test_case)
  File "/mnt/test-data-volume/kubeflow-presubmit-kubeflow-e2e-minikube-614-0340221-1073-e21d/src/kubeflow/testing/py/kubeflow/testing/test_util.py", line 82, in wrap_test
    test_func()
  File "/mnt/test-data-volume/kubeflow-presubmit-kubeflow-e2e-minikube-614-0340221-1073-e21d/src/kubeflow/kubeflow/testing/test_deploy.py", line 305, in run
    args.func(args)
  File "/mnt/test-data-volume/kubeflow-presubmit-kubeflow-e2e-minikube-614-0340221-1073-e21d/src/kubeflow/kubeflow/testing/test_deploy.py", line 445, in deploy_minikube
    vm_util.wait_for_vm(args.project, args.zone, args.vm_name)
  File "/mnt/test-data-volume/kubeflow-presubmit-kubeflow-e2e-minikube-614-0340221-1073-e21d/src/kubeflow/kubeflow/testing/vm_util.py", line 37, in wait_for_vm
    "Timed out waiting for op: {0} to complete.".format(op_id))
NameError: global name 'op_id' is not defined

The NameError looks like a typo in the exception handling and not the actual error.

@pdmack
Copy link
Member

pdmack commented Apr 9, 2018

/retest

@jlewi
Copy link
Contributor

jlewi commented Apr 9, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e778fcc into master Apr 9, 2018
@gaocegege gaocegege deleted the images branch June 18, 2018 12:48
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
@gaocegege @k8s-ci-robot
images: Add the link (kubeflow#614)
da4c729
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
@andreyvelich @k8s-ci-robot
Training Container for NAS RL Suggestion in v1alpha2 (kubeflow#614)
32d3401 
* Add training container in v1alpha2

* Modify runTrial
surajkota pushed a commit to surajkota/kubeflow that referenced this pull request Jun 13, 2022
@jlewi @k8s-ci-robot
Remove the E2E test. (kubeflow#614)
4763c64 
* The e2e test is failing because kfctl has moved from kubeflow/kubeflow
  to kubfelow/kfctl (kubeflow/kfctl#7)

* The existing E2E test is an outdated copy of the old ksonnet workflow

* To unblock presubmits we are just deleting this test

* In a subsequent PR we will add back an E2E test but avoid duplicating the
  test and just check the test out from kubeflow/kubeflow or kubeflow/kfctl

related: kubeflow/manifests#613
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlewi jlewi Awaiting requested review from jlewi

Assignees

@jlewi jlewi

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gaocegege @jlewi @pdmack @k8s-ci-robot